Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the option to send daily recap by email (#5733) #5962

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Added the option to send daily recap by email (#5733) #5962

merged 1 commit into from
Mar 8, 2024
+1,019 −371

Conversation

ClementBouvierN
Copy link
Contributor

@ClementBouvierN ClementBouvierN linked an issue Feb 21, 2024 that may be closed by this pull request
Add an option to receive mail on a daily basis #5733
Closed
@ClementBouvierN ClementBouvierN marked this pull request as draft February 21, 2024 16:30
@freddidierRTE freddidierRTE self-assigned this Feb 23, 2024
@ClementBouvierN ClementBouvierN force-pushed the FE-5733-DailyMail branch 3 times, most recently from 0f2a7c6 to eb67047 Compare March 5, 2024 12:32
freddidierRTE
freddidierRTE reviewed Mar 5, 2024
View reviewed changes
Copy link
Contributor

@freddidierRTE freddidierRTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solve two sonar issues regarding unused import

node-services/cards-external-diffusion/src/domain/application/dailyCardsDiffusionControl.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/application/dailyCardsDiffusionControl.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/client-side/cardsExternalDiffusionService.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/client-side/configService.ts Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/client-side/cardsExternalDiffusionService.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/client-side/cardsExternalDiffusionService.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/application/dailyCardsDiffusionControl.ts Outdated Show resolved Hide resolved
src/test/api/karate/cards-external-diffusion/cardsExternalDiffusion.feature Outdated Show resolved Hide resolved
@ClementBouvierN ClementBouvierN marked this pull request as ready for review March 6, 2024 13:52
@ClementBouvierN ClementBouvierN force-pushed the FE-5733-DailyMail branch 2 times, most recently from d5891c2 to daf1943 Compare March 6, 2024 15:20
freddidierRTE
freddidierRTE requested changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@freddidierRTE freddidierRTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add dailyEmailTitle , hourToSendDailyEmail , minuteToSendDailyEmail in documentation : https://opfab.github.io/documentation/current/deployment/#cards-external-diffusion-conf

node-services/cards-external-diffusion/src/domain/client-side/cardsExternalDiffusionService.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/tests/dailyCardsDiffusionControl.test.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/tests/dailyCardsDiffusionControl.test.ts Outdated Show resolved Hide resolved
node-services/cards-external-diffusion/src/domain/application/cardsDiffusionControl.ts Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@freddidierRTE freddidierRTE merged commit d43c160 into develop Mar 8, 2024
8 checks passed
@freddidierRTE freddidierRTE deleted the FE-5733-DailyMail branch March 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddidierRTE freddidierRTE freddidierRTE requested changes

Assignees

@freddidierRTE freddidierRTE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an option to receive mail on a daily basis
2 participants
@ClementBouvierN @freddidierRTE